feat: print port in the logged error message after failed WS connection with EADDRINUSE
#19212
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
changed the title
port in the logged error message after failed WS connection with EADDRINUSEport in the logged error message after failed WS connection with EADDRINUSE
… connection with `EADDRINUSE`
patak-dev
changed the title
port in the logged error message after failed WS connection with EADDRINUSEport in the logged error message after failed WS connection with EADDRINUSE
patak-dev
approved these changes
Jan 16, 2025
patak-dev
added
the
p2-nice-to-have
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is just a small QoL improvement, following the same error message as the one reported here:
vite/packages/vite/src/node/http.ts
Line 160 in 4f5845a